Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #774 - Fix NRTM generator performance on PyPy #777

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Fix #774 - Fix NRTM generator performance on PyPy #777

merged 2 commits into from
Apr 19, 2023

Conversation

mxsasha
Copy link
Collaborator

@mxsasha mxsasha commented Apr 19, 2023 •
edited
Loading

Apparently, PyPy deals quite poorly when extending the same string many times, as the old code did. Requesting 500.000 serials in one NRTM query, response 181MB, was now ~30 seconds on both PyPy and CPython in a testing setup.

@mxsasha mxsasha linked an issue Apr 19, 2023 that may be closed by this pull request
NRTM responses can hang on PyPy #774
Closed
@mxsasha mxsasha self-assigned this Apr 19, 2023
@mxsasha mxsasha enabled auto-merge (squash) April 19, 2023 10:54
@mxsasha mxsasha merged commit 87bceb8 into main Apr 19, 2023
@mxsasha mxsasha deleted the fix-nrtm-pypy branch April 19, 2023 11:05
mergify bot pushed a commit that referenced this pull request Apr 19, 2023
@mxsasha @mergify
Fix #774 - Fix NRTM generator performance on PyPy (#777)
2ddb8a0 
Apparently, PyPy deals quite poorly when extending the same string many times, as the old code did. More details in #774 / #777.

(cherry picked from commit 87bceb8)

# Conflicts:
#	irrd/mirroring/nrtm_generator.py
@mergify mergify bot mentioned this pull request Apr 19, 2023
Merged
mergify bot pushed a commit that referenced this pull request Apr 19, 2023
@mxsasha @mergify
Fix #774 - Fix NRTM generator performance on PyPy (#777)
78b1f7c 
Apparently, PyPy deals quite poorly when extending the same string many times, as the old code did. More details in #774 / #777.

(cherry picked from commit 87bceb8)
@mergify mergify bot mentioned this pull request Apr 19, 2023
Merged
mxsasha added a commit that referenced this pull request Apr 19, 2023
@mergify @mxsasha
[4.3.x] Fix #774 - Fix NRTM generator performance on PyPy (#777) (#779)
e275171 
Apparently, PyPy deals quite poorly when extending the same string many times, as the old code did. More details in #774 / #777.

(cherry picked from commit 87bceb8)

Co-authored-by: Sasha Romijn <github@mxsasha.eu>
mxsasha added a commit that referenced this pull request Apr 19, 2023
@mergify @mxsasha
[4.2.x] Fix #774 - Fix NRTM generator performance on PyPy (backport #777
c2951ed 
) (#778)

Apparently, PyPy deals quite poorly when extending the same string many times, as the old code did. More details in #774 / #777.

(cherry picked from commit 87bceb8)

Co-authored-by: Sasha Romijn <github@mxsasha.eu>
@mxsasha mxsasha mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mxsasha mxsasha

Labels
backport-to-4.2 backport-to-4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NRTM responses can hang on PyPy
1 participant
@mxsasha