Minimum set of changes to make bindings work locally #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irvinebroque
commented
Dec 23, 2023
| @@ -34,3 +34,6 @@ yarn-error.log* | |||
| # typescript | |||
| *.tsbuildinfo | |||
| next-env.d.ts | |||
|
|
|||
| # wrangler | |||
| .wrangler | |||
There was a problem hiding this comment.
The template we give people should ignore .wrangler, otherwise you end up committing the temp state of local dev to git history accidentally.
| @@ -2,3 +2,17 @@ | |||
| const nextConfig = {} | |||
|
|
|||
| module.exports = nextConfig | |||
|
|
|||
| // Everything below *needs* to be part of the default template that running npm create cloudflare@latest gives you | |||
There was a problem hiding this comment.
^ needs to be default, not opt-in.
| @@ -2,3 +2,17 @@ | |||
| const nextConfig = {} | |||
|
|
|||
| module.exports = nextConfig | |||
|
|
|||
| // Everything below *needs* to be part of the default template that running npm create cloudflare@latest gives you | |||
| // It needs to be documented in real dev docs | |||
There was a problem hiding this comment.
This has to be loud, at the top of any getting started path we have (since many people will have existing Next.js apps, or be creating them outside of npm create cloudflare@latest, outside of dash.
| // Everything below *needs* to be part of the default template that running npm create cloudflare@latest gives you | ||
| // It needs to be documented in real dev docs | ||
| // It needs to be the happy path, not optional thing you discover later | ||
| // Assume that every single developer will use one or more of these in their app |
| if (process.env.NODE_ENV === 'development') { | ||
| import('@cloudflare/next-on-pages/__experimental__next-dev').then(({ setupDevBindings }) => { | ||
|
|
||
| // When Pages has wrangler.toml, just read from that in current directory and can skip this config |
There was a problem hiding this comment.
This is a big part of why getting Pages wrangler.toml matters so much.
| // When Pages has wrangler.toml, just read from that in current directory and can skip this config | ||
| setupDevBindings({ | ||
| kvNamespaces: ['MY_KV_1', 'MY_KV_2'], | ||
| }); |
There was a problem hiding this comment.
^ this is effectively making people re-create what would otherwise be in wrangler.toml.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.