Skip to content

Commit

Permalink
Restricts the protobuf version to <5.0.0 in setup.py (#413)
Browse files Browse the repository at this point in the history
# Description

Restricts the protobuf version to <5.0.0 in setup.py and closes
#412

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

| Before | After |
| ------ | ----- |
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/cc41ae19-a22c-472b-8ab8-aa21d2b0b55d)
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/eabf360b-5205-4eb6-a6ca-9403a94ad6d5)
|


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
  • Loading branch information
MuhongGuo authored May 31, 2024
1 parent 1928161 commit 71989e7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ Guidelines for modifications:
* Chenyu Yang
* Jia Lin Yuan
* Jingzhou Liu
* Kourosh Darvish
* Lorenz Wellhausen
* Muhong Guo
* Kourosh Darvish
* Özhan Özen
* Qinxi Yu
* René Zurbrügg
Expand Down
4 changes: 3 additions & 1 deletion source/extensions/omni.isaac.orbit_tasks/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
"numpy",
"torch==2.0.1",
"torchvision>=0.14.1", # ensure compatibility with torch 1.13.1
"protobuf>=3.20.2",
# 5.26.0 introduced a breaking change, so we restricted it for now.
# See issue https://github.com/tensorflow/tensorboard/issues/6808 for details.
"protobuf >= 3.19.6, < 5.0.0",
# data collection
"h5py",
# basic logger
Expand Down

0 comments on commit 71989e7

Please sign in to comment.