fix bug in generating target_frame_body_names #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao <15166943+taochenshh@users.noreply.github.com>
|
Sorry i think it got closed by accident. Will fix that later next week! |
|
@Mayankm96 hi Mayank, just wanna follow up on this issue and see if it would be resolved soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix on the target_frame_body_names. The original code might include the source frame instead since the frame order is not guaranteed to be preserved.
Fixes #170
Type of change
Checklist
pre-commitchecks with./orbit.sh --formatconfig/extension.tomlfile