Fixes typo in the check_instanceable.py script #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junfeng-Long
pushed a commit
to Junfeng-Long/IsaacLab
that referenced
this pull request
Feb 27, 2024
# Description This MR makes a critical fix for the assets classes `reset` mechanism. Particularly, the `write_` methods for the physics handles. Before, the root and joint states were reset for all environments rather than the specific `env_ids` concerned with the reset. This caused instabilities in the dynamics, but it was not necessarily perceivable in environments with spread-out resets like ANYmal. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Junfeng-Long
pushed a commit
to Junfeng-Long/IsaacLab
that referenced
this pull request
Feb 27, 2024
# Description To resolve all environment indices, the previous implementation used `self._ALL_INDICES`. However, this is not broadcastable when tensors are indexed with two lists, for example: ```python import torch x = torch.zeros(100, 25) x[[0, 2, 3, 4], [1, 2, 3]] ``` This MR fixes this bug (introduced in isaac-sim#248). ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Mayankm96
changed the title
|
Thanks a lot for sending the fix :) |
|
My pleasure :) I've been trying Orbit and I want it to be better
…On Thu, Feb 29, 2024 at 12:44 PM Mayank Mittal ***@***.***> wrote:
Thanks a lot for sending the fix :)
—
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVHEOOQWRXNEALNF6GSKMVTYV3U6JAVCNFSM6AAAAABDOC2PIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGY3DOOJWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description This MR makes a critical fix for the assets classes `reset` mechanism. Particularly, the `write_` methods for the physics handles. Before, the root and joint states were reset for all environments rather than the specific `env_ids` concerned with the reset. This caused instabilities in the dynamics, but it was not necessarily perceivable in environments with spread-out resets like ANYmal. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description To resolve all environment indices, the previous implementation used `self._ALL_INDICES`. However, this is not broadcastable when tensors are indexed with two lists, for example: ```python import torch x = torch.zeros(100, 25) x[[0, 2, 3, 4], [1, 2, 3]] ``` This MR fixes this bug (introduced in isaac-sim#248). ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description
In line 106 of the `check_instanceable.py` script, there is a typo
error.
The line goes as:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.usd_path))
```
but should be:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.input))
```
Fixes isaac-sim#242
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Checklist
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
Note: These 5 symbols that I changed do not require putting my name on
the contributors list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In line 106 of the
check_instanceable.pyscript, there is a typo error.The line goes as:
but should be:
Fixes #242
Type of change
Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileNote: These 5 symbols that I changed do not require putting my name on the contributors list.