Removes duplicated cassie configuration in core extension #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
MuhongGuo
force-pushed
the
fix/remove-duplicated-cassie-asset
branch
from
aff2582
to
c724a9a
Compare
|
Great catch! Does this MR delete the whole |
Yes, the
|
|
Thank you! :) |
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description We frequently reinstall pip packages when building the docker, even when the downloaded packages have not changed between builds. This allows us to look in `/root/.cache/pip` (on the image) for cached pip packages. This speeds up our build significantly. Adds a [mount cache ](https://docs.docker.com/build/cache/#use-the-dedicated-run-cache)to the Dockerfile for the line `${ORBIT_PATH}/orbit.sh --install --extra`, significantly increasing speeds by preventing repeated downloads of large packages ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
) # Description The `cassie.py` under the `omni.isaac.orbit` extension looks duplicated with the one under `omni.isaac.orbit_assets`, and after a search in the folder, I found that it's not being used or referenced at all. This MR removes it to avoid potential confusion. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cassie.pyunder theomni.isaac.orbitextension looks duplicated with the one underomni.isaac.orbit_assets, and after a search in the folder, I found that it's not being used or referenced at all. This MR removes it to avoid potential confusion.Type of change
Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there