Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extensions to VSCode python.analysis.extraPaths settings #526

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

fuyh20
Copy link
Contributor

@fuyh20 fuyh20 commented Jun 18, 2024

Description

I added the path of isaac lab extensions to vscode python.analysis.extraPaths to execute intelligent prompt in vscode properly.

Fixes #463

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

In .vscode/tools/setup_vscode.py
f9429980-bf0b-4e28-917b-10c0eccc92ce

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./isaaclab.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96
Copy link
Contributor

Hi, is it possible to just have them inside the template JSON file instead of the python script?

https://github.com/isaac-sim/IsaacLab/blob/main/.vscode/tools/settings.template.json#L84

@Mayankm96 Mayankm96 self-requested a review June 18, 2024 09:04
@Mayankm96 Mayankm96 added the bug Something isn't working label Jun 18, 2024
@fuyh20
Copy link
Contributor Author

fuyh20 commented Jun 18, 2024

Hi, is it possible to just have them inside the template JSON file instead of the python script?

https://github.com/isaac-sim/IsaacLab/blob/main/.vscode/tools/settings.template.json#L84

Sorry, currently I don't have a better solution except to directly hard-code the path into the template JSON file

@Mayankm96 Mayankm96 changed the title Adds the path of isaac lab extensions to vscode python.analysis.extraPaths Adds extensions to VSCode python.analysis.extraPaths settings Jun 25, 2024
@Mayankm96 Mayankm96 merged commit f486eb6 into isaac-sim:main Jun 25, 2024
1 check failed
Mayankm96 pushed a commit that referenced this pull request Jun 25, 2024
This MR adds the path of the isaac lab extensions to vscode
`python.analysis.extraPaths` to execute intelligent prompt in vscode
properly.

Fixes #463

- Bug fix (non-breaking change which fixes an issue)

In  .vscode/tools/setup_vscode.py

![f9429980-bf0b-4e28-917b-10c0eccc92ce](https://github.com/isaac-sim/IsaacLab/assets/75050508/18cf4868-28be-4907-ae6e-be287ff946b1)

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./isaaclab.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Mayankm96 pushed a commit that referenced this pull request Jun 25, 2024
This MR adds the path of the isaac lab extensions to vscode
`python.analysis.extraPaths` to execute intelligent prompt in vscode
properly.

Fixes #463

- Bug fix (non-breaking change which fixes an issue)

In  .vscode/tools/setup_vscode.py

![f9429980-bf0b-4e28-917b-10c0eccc92ce](https://github.com/isaac-sim/IsaacLab/assets/75050508/18cf4868-28be-4907-ae6e-be287ff946b1)

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./isaaclab.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
This MR adds the path of the isaac lab extensions to vscode
`python.analysis.extraPaths` to execute intelligent prompt in vscode
properly.

Fixes isaac-sim#463

- Bug fix (non-breaking change which fixes an issue)

In  .vscode/tools/setup_vscode.py

![f9429980-bf0b-4e28-917b-10c0eccc92ce](https://github.com/isaac-sim/IsaacLab/assets/75050508/18cf4868-28be-4907-ae6e-be287ff946b1)

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./isaaclab.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vscode intelligent prompt question
2 participants