Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to DuckDB v0.10.0 #82

Merged
merged 12 commits into from
Feb 22, 2024
Merged

Upgrade to DuckDB v0.10.0 #82

merged 12 commits into from
Feb 22, 2024

Conversation

isaacbrodsky
Copy link
Owner

Replaces #81

@isaacbrodsky isaacbrodsky mentioned this pull request Feb 20, 2024
@isaacbrodsky
Copy link
Owner Author

Note that on Windows I needed this change, which doesn't seem to be applicable for CI:

$ git diff
diff --git a/Makefile b/Makefile
index d81ae87..03fb4b4 100644
--- a/Makefile
+++ b/Makefile
@@ -10,10 +10,11 @@ DUCKDB_PATH="/duckdb"

 # For non-MinGW windows the path is slightly different
 ifeq ($(OS),Windows_NT)
-ifneq ($(CXX),g++)
+# TODO: Doesn't match what should actually happen
+# ifneq ($(CXX),g++)
        TEST_PATH="/test/Release/unittest.exe"
        DUCKDB_PATH="/Release/duckdb.exe"
-endif
+# endif
 endif

 #### OSX config

@isaacbrodsky isaacbrodsky merged commit ee3523f into main Feb 22, 2024
16 checks passed
@isaacbrodsky isaacbrodsky deleted the upgrade-v0.10.0 branch February 22, 2024 05:53
@eknowles
Copy link

thank you so much 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants