Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove formatting by default #85

Closed
wants to merge 1 commit into from
Closed

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Feb 27, 2024

While cross compiling (in particular to duckdb-wasm) linter does fail, so having some kind of escape hatch would be nice.
It also seems to me that it's somehow wasteful to iterate those check on every build. Would it make sense to have either them turned off by default (both for this and for the underlying library)?

Would it be possible to have this turned off by default ? Or alternatively having ENABLE_LINTING set to TRUE (so keeping same behaviour) but at least it becomes possible to opt-out?

Thanks!

@isaacbrodsky
Copy link
Owner

isaacbrodsky commented Feb 28, 2024

Thanks for the contribution. I can see that having this tooling run all the time isn't useful when not making changes to the library. I also noted that the wasm builds were having issues but I didn't have time to look into getting the CI for them working. Do you know if anything else is needed to get h3-duckdb building on wasm?

I have a slightly modified version of this in #86, could you take a look at whether that works as well? It preserves the option to run automatic code formatting but keeps it off by default.

@carlopi
Copy link
Contributor Author

carlopi commented Feb 28, 2024

I think effect is the same, and your is cleaner. Thanks!

@carlopi carlopi closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants