Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split amounts should use '$' for their line code #45

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

teeberg
Copy link
Contributor

@teeberg teeberg commented Feb 3, 2023

I'm trying to generate QIF files to import into GnuCash and found two issues that made this process a little bumpy. This is one of them.

With the current QIF formatting of splits, GnuCash will ignore the splits. Comparing the files that qiffen generates with other example files I found on the internet where GnuCash imports splits correctly, I noticed that qiffen writes split amounts using a line code of T, which is the line code for the amount of the overall transaction. Using a $ line code instead makes it work in GnuCash.

Judging by e.g. https://en.wikipedia.org/wiki/Quicken_Interchange_Format, I think GnuCash is in the right here, and qiffen should in fact be using a line code of $ instead of T.

Hence this PR! :) Let me know if there's anything else you'd like me to do!

Copy link
Owner

@isaacharrisholt isaacharrisholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. This is an oversight on my part, I think. Thanks for bringing it to my attention! The more people we get using this, the more things like this that'll crop up and get fixed.

@isaacharrisholt isaacharrisholt merged commit feaca62 into isaacharrisholt:main Feb 4, 2023
@teeberg teeberg deleted the split-amount-symbol branch February 5, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants