avoid process.binding() where possible #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process.binding() is deprecated. When running recent versions of Node.js with --pending-deprecation, the current code results in a printed warning about process.binding() usage. process.binding() is used to create writev(), but Node.js now exposes fs.writev(). Use that instead when it exists. Otherwise, fall back to the polyfill. This will avoid runtime deprecation messages for end users. If the minimum supported engine is ever Node.js 12.9.0 or above, the polyfill code should be removable at that time.
isaacs
approved these changes
Jan 13, 2020
mikemimik
previously requested changes
Jan 13, 2020
isaacs
reviewed
Jan 13, 2020
|
@Trott are these changes |
I believe this will support all versions of Node.js that the current version supports. It uses the new feature if it exists, otherwise it falls back to the previous code. |
|
(Pushed another commit to add a comment indicating that the polyfill block is needed for Node.js earlier than 12.9.0 so that it can be removed in a few years if support for earlier versions is no longer needed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.binding() is deprecated. When running recent versions of Node.js
with --pending-deprecation, the current code results in a printed
warning about process.binding() usage. process.binding() is used to
create writev(), but Node.js now exposes fs.writev(). Use that instead
when it exists. Otherwise, fall back to the polyfill. This will avoid
runtime deprecation messages for end users.
If the minimum supported engine is ever Node.js 12.9.0 or above, the
polyfill code should be removable at that time.