Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the LICENSE file? #459

Closed
hyandell opened this issue Mar 3, 2022 · 4 comments
Closed

Splitting the LICENSE file? #459

hyandell opened this issue Mar 3, 2022 · 4 comments

Comments

@hyandell
Copy link

hyandell commented Mar 3, 2022

Hi Glob folk,

I'm a part of the Open Source Program Office at AWS and wanted to let you know of a licensing painpoint. When pulling down updated npm packages, the glob package, and packages that include glob, always raise an eyebrow because of the CC-BY-SA license for the logo being mentioned. CC-BY-SA is a curious license for software, thus I get alerts to review. It's the more frustrating because the logo isn't included in the npm package file :)

I thought I'd share this because it's very unique to this project. "Oh, it's the glob text" might be something I mutter on a whole bunch of import-alerts :) I don't expect you to rate my pain highly, frankly the logo is awesome and it's great that it's being called out. But I did wonder if the license of the logo could move out into a separate LOGO-LICENSE file, which then isn't included in the npm package?

Apologies if this is too selfish a suggestion.

@isaacs
Copy link
Owner

isaacs commented Mar 3, 2022

Would it solve your problem if the CC-BY-SA was called out in the README.md but not in the license file? Since it's not distributed with the code on npm, that seems like it'd be fine. Though, I guess it is distributed with the code via GitHub. @tanyabrassie you own the copyright on that little guy, what's your thoughts?

@tanyabrassie
Copy link
Contributor

@isaacs @hyandell that's fine with me!

@kellertk
Copy link
Contributor

Hello glob people!

Another friendly AWS dev here - I'm unrelated to the team that validates licensing at AWS but I am a consumer of packages that consume glob as a dependency. For some more context, we have automated (and non-automated) systems that review open source licensing to make sure that we're in compliance, and because they're unusual for software, the Creative Commons licenses require manual review. Other packages (for example, @vercel/ncc) are bundling glob's LICENSE file in their distribution, which is flagging the licensing exception - as well as any AWS package that includes glob as a first level dependency.

I've created a simple PR (#463) that removes the information from the LICENSE file. Please let me know if this isn't appropriate.

isaacs pushed a commit that referenced this issue Mar 18, 2022
Remove the glob logo licensing information from LICENSE as this
information is already in README.md. See #459.

PR-URL: #463
Credit: @kellertk
Close: #463
Reviewed-by: @isaacs
@hyandell
Copy link
Author

Thank you @isaacs and @tanyabrassie for being so understanding :)

@isaacs isaacs closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants