Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore option is not working with relative path #570

Closed
Ffloriel opened this issue Nov 7, 2023 · 1 comment
Closed

ignore option is not working with relative path #570

Ffloriel opened this issue Nov 7, 2023 · 1 comment

Comments

@Ffloriel
Copy link

Ffloriel commented Nov 7, 2023

ignore using a relative path is not working as expected with the cwd option.
For context, this is used in this repo. When attempting to update from 8 to 10, the tests are failing because of this issue.

To reproduce, in node-glob/test/ignore.ts, you can add the following test case:

  [
    './*',
    './b',
    j(['abcdef', 'abcfed', 'bc', 'c', 'cb', 'symlink', 'x', 'z']),
    'a',
  ],
mmkal added a commit to mmkal/eslint-plugin-codegen that referenced this issue Jan 18, 2024
fixes #20

workaround for isaacs/node-glob#570

Co-authored-by: Misha Kaletsky <mmkal@users.noreply.github.com>
Ffloriel added a commit to FullHuman/purgecss that referenced this issue Feb 3, 2024
Ffloriel added a commit to FullHuman/purgecss that referenced this issue Feb 3, 2024
* build(deps): bump glob from 8.0.3 to 10.3.10

Bumps [glob](https://github.com/isaacs/node-glob) from 8.0.3 to 10.3.10.
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](isaacs/node-glob@v8.0.3...v10.3.10)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* workaround for isaacs/node-glob#570

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Floriel <Ffloriel@users.noreply.github.com>
@isaacs
Copy link
Owner

isaacs commented Mar 28, 2024

Specifically, this is an issue with an ignore pattern that starts with ./. Relative patterns starting with ../ or some other string or pattern work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants