fix: change the order of exports field keys to fix type resolution
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As both `./min` and `.` points to the same type definition file, sometimes TypeScript will resolve the type definition file to the `./min` key as it appears first. microsoft/TypeScript#56290 (comment) While this is not incorrect behavior, it breaks compatibility with older build environments that do not support the `exports` field. (e.g. TypeScript with `moduleResolution: "node"` instead of `bundler` or `node16`), as the `./min` entry is only available through the `exports` field. Some Vue.js users are experiencing this issue: vuejs/core#9521
VovaKukh
approved these changes
Nov 9, 2023
VovaKukh
approved these changes
Nov 9, 2023
|
As it happens, I'm in the middle of refactoring the artisanal hand-crafted build scripts to use tshy anyway, will do this as part of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As both
./minand.points to the same type definition file, sometimes TypeScript will resolve the type definition entry to the./minkey as it appears first.microsoft/TypeScript#56290 (comment)
While this is not incorrect behavior, it breaks compatibility with older build environments that do not support the
exportsfield. (e.g. TypeScript withmoduleResolution: "node"instead ofbundlerornode16), as the./minentry is only available through theexportsfield.Some Vue.js users are experiencing this issue:
vuejs/core#9521