Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the noChmod option #270

Merged
merged 6 commits into from
Jan 7, 2021
Merged

Add the noChmod option #270

merged 6 commits into from
Jan 7, 2021

Conversation

isaacs
Copy link
Owner

@isaacs isaacs commented Jan 5, 2021

This allows a way to suppress the call to process.umask() while
still being as compliant as possible with the modes as defined
in the tarball entries.

Re: npm/cli#1103

References

@isaacs isaacs requested a review from a team as a code owner January 5, 2021 23:34
@isaacs isaacs force-pushed the isaacs/no-chmod branch 2 times, most recently from fb05f55 to 8861b07 Compare January 6, 2021 00:28
@isaacs isaacs mentioned this pull request Jan 6, 2021
Merged
@isaacs isaacs force-pushed the isaacs/no-chmod branch 3 times, most recently from 43422ff to c9f4e18 Compare January 6, 2021 23:52
@isaacs isaacs mentioned this pull request Jan 7, 2021
Closed
@isaacs
Copy link
Owner Author

isaacs commented Jan 7, 2021 •
edited
Loading

  1. Land this
  2. Bump minor version and publish
  3. Update pacote to depend on bumped tar version Isaacs/no chmod npm/pacote#57
  4. Bump patch on pacote and publish (it's not a new feature in pacote, just an optimization)
  5. Update arborist to use bumped pacote version
  6. Install updated pacote and tar in cli, land Remove process.umask() call from config default npm/cli#2444

nlf
nlf approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isaacs @ruyadorno
test: provide more garbagey gzip data for zlib fail test
0f1211f
@isaacs @ruyadorno
actions: turn on core.longpaths for windows
e753c9d
@isaacs @ruyadorno
always use LF line endings for test fixtures
ad43c86 
Otherwise all the tests fail
@isaacs @ruyadorno
ci: turn off windows tests for now
bfa1f24
@isaacs @ruyadorno
Skip known-bad test on old Node.js versions
73ec0f7
@isaacs @ruyadorno
Add the noChmod option
2d83d5b 
This allows a way to suppress the call to process.umask() while
still being as compliant as possible with the modes as defined
in the tarball entries.

Re: npm/cli#1103

PR-URL: #270
Credit: @isaacs
Close: #270
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno closed this in 2d83d5b Jan 7, 2021
@ruyadorno ruyadorno merged commit 2d83d5b into master Jan 7, 2021
@isaacs isaacs deleted the isaacs/no-chmod branch July 23, 2021 22:49
@jnv jnv mentioned this pull request Oct 20, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacs @nlf @ruyadorno