Entities with XML elements

isaacs · Sep 26, 2023 · b4dd742 · b4dd742
1 parent 88220a2
commit b4dd742
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/sax.js b/lib/sax.js
@@ -1483,9 +1483,11 @@
           }
 
           if (c === ';') {
-            parser[buffer] += parseEntity(parser)
+            // parser[buffer] += parseEntity(parser)
+            var parsedEntity = parseEntity(parser)
             parser.entity = ''
             parser.state = returnState
+            parser.write(parsedEntity)
           } else if (isMatch(parser.entity.length ? entityBody : entityStart, c)) {
             parser.entity += c
           } else {

diff --git a/test/entity-elem.js b/test/entity-elem.js
@@ -0,0 +1,18 @@
+var sax = require('../');
+sax.ENTITIES.attr = "1";
+sax.ENTITIES.text = "2";
+sax.ENTITIES.elem = '<B ATTR="&attr;.3"/>';
+require(__dirname).test({
+  xml: `<A ATTR="&attr;.2">&text;&elem;</A>`,
+  expect: [
+    ["opentagstart", {name: "A", attributes: {}}],
+    ["attribute", {name: 'ATTR', value: "1.2"}],
+    ["opentag", {name: "A", attributes: {ATTR: "1.2"}, isSelfClosing: false}],
+    ["text", "2"],
+    ["opentagstart", {name: "B", attributes: {}}],
+    ["attribute", {name: 'ATTR', value: "1.3"}],
+    ["opentag", {name: "B", attributes: {ATTR: "1.3"}, isSelfClosing: true}],
+    ["closetag", "B"],
+    ["closetag", "A"]
+  ]
+});