Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support python >= 3.8 #53

Merged
merged 9 commits into from
Feb 20, 2024
Merged

feat!: support python >= 3.8 #53

merged 9 commits into from
Feb 20, 2024

Conversation

isac322
Copy link
Owner

@isac322 isac322 commented Feb 20, 2024

Follow up #52

Fixes #51

* Update dependencies using poetry
* Remove python 3.6 support (no longer supported by `marisa-trie`
dependency)
* Add tox configuration to test multiple python versions locally
* Update CI python versions

Closes #51
@isac322 isac322 self-assigned this Feb 20, 2024
@isac322
Copy link
Owner Author

isac322 commented Feb 20, 2024

@utlandr I will track the progress of your pull request in this PR.

Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba55f57) 96.94% compared to head (ae371d8) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   96.94%   96.80%   -0.15%     
==========================================
  Files           3        3              
  Lines         131      125       -6     
==========================================
- Hits          127      121       -6     
  Misses          4        4              
Flag Coverage Δ
3.1 ?
3.10 96.00% <100.00%> (?)
3.11 96.00% <100.00%> (?)
3.12 96.00% <100.00%> (?)
3.6 ?
3.7 ?
3.8 96.00% <100.00%> (+2.10%) ⬆️
3.9 96.00% <100.00%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Byeonghoon Yoo <bhyoo@bhyoo.com>
This reverts commit 05bdda5.
@isac322 isac322 merged commit 3173f2f into master Feb 20, 2024
8 checks passed
@isac322 isac322 deleted the py312 branch February 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install on Python 3.12
2 participants