-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: cdfInverse does not accept a value of 1 as q #21
Comments
yikes, I thought I tested that |
For some reason I tend to find the edge cases! |
I'll try to make some time to fix this over the weekend, thanks for reporting! |
Thanks for fixing this quickly. Are you going to be releasing a minor with
the fixes soon?
Le dim. 24 janv. 2021 à 17:58, Erik Erlandson <notifications@github.com> a
écrit :
… Closed #21 <#21> via
2dcb37d
<2dcb37d>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKLNVXQLGQRNY5FEQOV3XDS3RGU5ANCNFSM4WK2OIDA>
.
|
Yes, I would have released it already but I lost my login to Sonatype and they're being weirdly unresponsive helping me restore it 😕 If I can't get it resolved soon, I may migrate the build to github or bintray |
@JonathanTaws I got my sonatype creds sorted out again, new release is available: |
The
cdfInverse
method is supposed to acceptqq
values in range[0,1]
as explained in the doc (note that the doc mentionsq
, whileqq
is the actual parameter used):isarn-sketches-spark/python/isarnproject/sketches/spark/tdigest.py
Lines 305 to 309 in e7d3136
However, if I give the value
1
, I get anIndexError: list index out of range
. The error comes from here:isarn-sketches-spark/python/isarnproject/sketches/spark/tdigest.py
Line 318 in e7d3136
How to reproduce (using the example on the github page https://github.com/isarn/isarn-sketches-spark#sketch-a-numeric-column-python):
Result:
This code runs
isarn-sketches-spark_2.12:0.5.0-sp3.0
. However, in versionisarn-sketches-spark_2.11:0.3.1-sp2.2-py2.7
, thecdfInverse
used to accept a value of1
and run with it.The text was updated successfully, but these errors were encountered: