Skip to content

Commit

Permalink
Fix forgotten interface declaration change (#62)
Browse files Browse the repository at this point in the history
* Fix application breaking on js interop error

Instead, it now catches the exception and stops tracking the connection.

* Change method signature for async method without await

* Remove unnecessary calls to base class initialization

* Remove unsubscription from initialization method

* Implement IDisposable and have unsubscribe occur there

* Change from OnInitializedAsync to OnIntialized

* Change IAnalytics interface for ConfigureGlobalEventData to be synchronous

* Remove accidental async addition in interface
  • Loading branch information
scott-parkhill authored Mar 30, 2023
1 parent 19eb521 commit dd82bf7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Blazor.Analytics/Abstractions/IAnalytics.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Blazor.Analytics
public interface IAnalytics
{
Task ConfigureGlobalConfigData(Dictionary<string, object> globalConfigData);
Task ConfigureGlobalEventData(Dictionary<string, object> globalEventData);
void ConfigureGlobalEventData(Dictionary<string, object> globalEventData);

Task TrackNavigation(string uri);

Expand Down

0 comments on commit dd82bf7

Please sign in to comment.