prepare_operations: avoid crash when no rasters provided

isciences · Aug 29, 2024 · 399d0cb · 399d0cb
1 parent 8bec482
commit 399d0cb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/utils.cpp b/src/utils.cpp
@@ -342,6 +342,10 @@ prepare_operations(
   const RasterSourceVect& rasters,
   const RasterSourceVect& weights)
 {
+    if (!descriptors.empty() && rasters.empty()) {
+        throw std::runtime_error("no rasters provided to prepare_operations");
+    }
+
     std::vector<std::unique_ptr<Operation>> ops;
 
     std::vector<StatDescriptor> parsed_descriptors;

diff --git a/test/test_utils.cpp b/test/test_utils.cpp
@@ -315,6 +315,16 @@ TEST_CASE("prepare_operations")
         CHECK(ops[0]->name == "mean");
         CHECK(ops[1]->name == "adj_mean");
     }
+
+    SECTION("error when no rasters are provided")
+    {
+        auto values = make_rasters("v", 0);
+        std::vector<std::unique_ptr<RasterSource>> weights;
+        std::vector<std::string> stats{ "sum" };
+
+        CHECK_THROWS_WITH(prepare_operations(stats, values, weights),
+                          Catch::Contains("no rasters provided"));
+    }
 }
 
 TEST_CASE("parsing arguments")