-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-threaded raster strategy #161
Open
shortcutman
wants to merge
24
commits into
isciences:master
Choose a base branch
from
shortcutman:parallel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t error needs confirmation.
…proscribed by the docs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 90.71% 90.47% -0.24%
==========================================
Files 85 85
Lines 6664 6751 +87
Branches 628 636 +8
==========================================
+ Hits 6045 6108 +63
- Misses 587 608 +21
- Partials 32 35 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new strategy to exact extract named
raster-parallel
.The strategy utilises oneAPI TBB to setup a parallel pipeline for finding intersecting features, reading raster data, performing zonal stats and merging stats for final output. Number of 'tokens' (TBB terminology, essentially maximum parallel tasks in flight) is controlled with the
--tokens [number]
command line argument.Implementation
Prior to the parallel pathway, logic is the same as
raster-sequential
where all features are read in and an STR tree is created for doing intersection.For the parallel pipeline:
Finally all features are written out with the same implementation as
raster-sequential
.Parallel considerations
Performance
Performing mean and count on ~1.6M polygons of Western Australia cadastral boundaries against ~25m square pixels of Australian agricultural land use data (with national coverage) done on Ryzen 7700 (8c/16t) with 32GB RAM:
feature-sequential
elapsed time: 7m 42s, maximum memory usage: 2.224 GBraster-sequential
elapsed time: 2m 52s, maximum memory usage: 4.639 GBraster-parallel
with 4 simultaneous tokens, elapsed time: 52s, max memory usage: 5.653 GBraster-parallel
with 8 simultaneous tokens, elapsed time: 37s, max memory usage: 5.823 GBraster-parallel
with 12 simultaneous tokens, elapsed time: 36s, max memory usage: 5.961 GBOther notes
All results were tested against
raster-sequential
outputs to control for any parallel bugs. Nothing major was observed other than occasional floating point errors at the end of its precision. I did not that multiple raster input toraster-sequential
doesn't look like it is working as intended, but out of scope for this PR.I didn't make any changes to the Python bindings or libs at this stage. I note that the actions continually fail on them but not sure why.
Welcome any comments, hope this is something that helps!