Avoid crashes on /proc/ish from CLI build #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbodt
reviewed
May 11, 2024
fs/proc/ish.c
Outdated
| @@ -55,6 +55,10 @@ static int proc_ish_show_colors(struct proc_entry *UNUSED(entry), struct proc_da | |||
| } | |||
|
|
|||
| static int proc_ish_show_documents(struct proc_entry *UNUSED(entry), struct proc_data *buf) { | |||
| if (get_documents_directory == NULL) { | |||
| proc_printf(buf, "\n"); | |||
| return 0; | |||
There was a problem hiding this comment.
Please fix indentation (is this perhaps using tabs instead of spaces or something?
There was a problem hiding this comment.
Yes, tabs. You may see these in C code occasionally. :)
You might want to add some style guidance to the docs, or enforce with clang-format, if it's important to you.
Also fixed in #2387
There was a problem hiding this comment.
The problem with it is that github renders tabs as four spaces, while your editor probably used eight... thus are the hazards of mixing indentation types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find /procsegfaults on CLI iSH.The CLI iSH does not implement some callouts that iSH's procfs provides for the GUI, and the procfs does not check that these callouts actually exist. This fixes that.