Support for login #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I really appreciate your efforts on this module and I will merge them as soon as I get to review and test them. I hope my coding style didn't put you off and would love to hear your thoughts and suggestions on it. In terms of renaming the package/repository, I will be doing that right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Nice library, good work!
I need to access my Huawei B315 and it has the exact same API as your Dialog device, and the internet seems to agree that other Huawei routers share it as well. Which of course does make sense.
I used your original sources of information and some time to get the login work correctly. So now it is possible to extend the library to do all the operations that are behind login (which of course is most of it).
What do you think? Worth a pull?
Also I would love for you to rename the npm package (and the repository) to something like huawei-router-api or similar, as my device is not Dialog branded and it might push others off as well.
Cheers,
Rolf