Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests suits to review, for codepipeline-actions-source #1

Conversation

ToniDarodda
Copy link

@ToniDarodda ToniDarodda commented Aug 5, 2024

Description of changes

The implementation of the CodeConnectionsSourceAction in AWS CodePipeline using AWS CDK requires thorough testing to ensure its functionality and robustness. This pull request introduces unit tests to validate the correct behavior of the CodeConnectionsSourceAction class, ensuring that it handles required properties, configurations, and interactions with AWS services correctly.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ToniDarodda, since the feature request is regarding the CodeConnections as source, can we create a test similar to codestar-connections-source-action.test.ts file, and use our newly created CodeConnections option test and place it in aws-codepipeline-actions/test/codeconnections directory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, of course, do you want me to delete the old one? the codepipeline-source-actions.test.ts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ToniDarodda sorry for the late response! Busy day at work as usual. You can keep it for now, before we get the upstream PR ready to merge we can do a quick review to get rid of non-relevant tests.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishon19 yeah sure

Copy link
Owner

@ishon19 ishon19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishon19
Copy link
Owner

ishon19 commented Aug 8, 2024

Thanks @ToniDarodda, I am merging the changes to my branch, then we can check if we need to do anything in the main PR.

@ishon19 ishon19 merged commit 030883d into ishon19:feat/30957-add-codeconnection-source-to-codepipeline Aug 8, 2024
6 of 7 checks passed
Copy link

github-actions bot commented Aug 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants