-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests suits to review, for codepipeline-actions-source #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ToniDarodda, since the feature request is regarding the CodeConnections
as source, can we create a test similar to codestar-connections-source-action.test.ts
file, and use our newly created CodeConnections
option test and place it in aws-codepipeline-actions/test/codeconnections
directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, of course, do you want me to delete the old one? the codepipeline-source-actions.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ToniDarodda sorry for the late response! Busy day at work as usual. You can keep it for now, before we get the upstream PR ready to merge we can do a quick review to get rid of non-relevant tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishon19 yeah sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @ToniDarodda, I am merging the changes to my branch, then we can check if we need to do anything in the main PR. |
030883d
into
ishon19:feat/30957-add-codeconnection-source-to-codepipeline
Comments on closed issues and PRs are hard for our team to see. |
Description of changes
The implementation of the CodeConnectionsSourceAction in AWS CodePipeline using AWS CDK requires thorough testing to ensure its functionality and robustness. This pull request introduces unit tests to validate the correct behavior of the CodeConnectionsSourceAction class, ensuring that it handles required properties, configurations, and interactions with AWS services correctly.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license