removed was-open check for combobox (#6178)

Co-authored-by: Rene Sepulveda <errissa@gmail.com>
isl-org · Oct 6, 2023 · 6cd52c8 · 6cd52c8
1 parent ea2001f
commit 6cd52c8
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/cpp/open3d/visualization/gui/Combobox.cpp b/cpp/open3d/visualization/gui/Combobox.cpp
@@ -147,8 +147,6 @@ Size Combobox::CalcPreferredSize(const LayoutContext& context,
 
 Combobox::DrawResult Combobox::Draw(const DrawContext& context) {
     bool value_changed = false;
-    bool was_open = ImGui::IsPopupOpen(impl_->imgui_id_.c_str());
-    bool did_open = false;
 
     auto& frame = GetFrame();
     ImGui::SetCursorScreenPos(
@@ -166,10 +164,8 @@ Combobox::DrawResult Combobox::Draw(const DrawContext& context) {
 
     DrawImGuiPushEnabledState();
     ImGui::PushItemWidth(float(frame.width));
+
     if (ImGui::BeginCombo(impl_->imgui_id_.c_str(), GetSelectedValue())) {
-        if (!was_open) {
-            did_open = true;
-        }
         for (size_t i = 0; i < impl_->items_.size(); ++i) {
             bool isSelected = false;
             if (ImGui::Selectable(impl_->items_[i].c_str(), &isSelected, 0)) {
@@ -185,13 +181,14 @@ Combobox::DrawResult Combobox::Draw(const DrawContext& context) {
         }
         ImGui::EndCombo();
     }
+
     ImGui::PopItemWidth();
     DrawImGuiPopEnabledState();
 
     ImGui::PopStyleColor(3);
 
-    return ((value_changed || did_open) ? Widget::DrawResult::REDRAW
-                                        : Widget::DrawResult::NONE);
+    return value_changed ? Widget::DrawResult::REDRAW
+                         : Widget::DrawResult::NONE;
 }
 
 }  // namespace gui