Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using wrong pip module for installing the pip package #3524

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

benjaminum
Copy link
Contributor

@benjaminum benjaminum commented May 31, 2021

This PR ensures that the install-pip-package target uses the pip module that matches the python environment.


This change is Reviewable

@benjaminum benjaminum requested a review from yxlao May 31, 2021 20:18
@update-docs
Copy link

update-docs bot commented May 31, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Collaborator

@yxlao yxlao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the test is passing.

There seems to be some issue with Windows + CUDA, could you double-check that?

@benjaminum
Copy link
Contributor Author

benjaminum commented Jun 1, 2021

@yxlao It seems to be related to the fmt library. Error messages do not make sense. Could be a duplicate definition.
#3456 has similar errors and also does have changes to CMake scripts. Seems like a small change to a cmake script can trigger this.

@stotko
Copy link
Contributor

stotko commented Jun 1, 2021

@yxlao It seems to be related to the fmt library. Error messages do not make sense. Could be a duplicate definition.
#3456 has similar errors and also does have changes to CMake scripts. Seems like a small change to a cmake script can trigger this.

The error in #3456 occurred after rebasing to the latest master branch changes and addressing some minor comments. First. I thought that this could be related to the latter part, but it now looks more like a regression coming from master in GitHub Actions' Windows CI image.

@stotko
Copy link
Contributor

stotko commented Jun 1, 2021

After checking a few things, this seems like a regression in GitHub Actions' Windows CI image. They recently upgraded Visual Studio 2019 from 16.9 to 16.10 which seems to introduce these error when compiling with CUDA.

Reference: actions/runner-images#3485

@benjaminum
Copy link
Contributor Author

After checking a few things, this seems like a regression in GitHub Actions' Windows CI image. They recently upgraded Visual Studio 2019 from 16.9 to 16.10 which seems to introduce these error when compiling with CUDA.

Reference: actions/virtual-environments#3485

This makes sense. I did re-run the Win CI for merged PR #3521 (basically master) and we get the same errors.

@germanros1987 germanros1987 merged commit 402babb into master Jun 1, 2021
@yxlao yxlao deleted the benjaminum/fix_install_wrong_pip branch June 1, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants