Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Visual Studio 16.10 compiler bug with CUDA and C++14 #3574

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

stotko
Copy link
Contributor

@stotko stotko commented Jun 11, 2021

This PR workarounds a newly introduced compiler bug in Visual Studio 16.10 when building with CUDA and C++14.

References:


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jun 11, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@stotko stotko force-pushed the stotko/workaround-windows-cuda-compiler-bug branch from 57ea63e to 89515f2 Compare June 11, 2021 17:15
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@stotko stotko force-pushed the stotko/workaround-windows-cuda-compiler-bug branch from 89515f2 to d3f0f92 Compare June 14, 2021 07:40
@stotko
Copy link
Contributor Author

stotko commented Jun 14, 2021

Thanks @Dudulle for helping me with the fix. I updated the PR according to your suggestions.

@stotko stotko marked this pull request as ready for review June 14, 2021 07:43
@stotko stotko requested review from yxlao and ssheorey June 14, 2021 07:43
Copy link
Collaborator

@yxlao yxlao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ssheorey and @stotko)

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @stotko)


CMakeLists.txt, line 235 at r2 (raw file):

    # Suppress warnings for deprecated C++17 functions.
    add_compile_definitions($<$<COMPILE_LANGUAGE:CUDA>:_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING>)
    message(WARNING "Visual Studio 16.10 introduced a compiler bug when compiling CUDA code with C++14. "

Mention MSVC version here (19.29).

@stotko stotko force-pushed the stotko/workaround-windows-cuda-compiler-bug branch from d3f0f92 to f9de553 Compare June 14, 2021 17:41
Copy link
Contributor Author

@stotko stotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ssheorey, @stotko, and @yxlao)


CMakeLists.txt, line 235 at r2 (raw file):

Previously, ssheorey wrote…

Mention MSVC version here (19.29).

Done.

@yxlao yxlao merged commit bd931d9 into master Jun 15, 2021
@yxlao yxlao deleted the stotko/workaround-windows-cuda-compiler-bug branch June 15, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants