-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround Visual Studio 16.10 compiler bug with CUDA and C++14 #3574
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
57ea63e
to
89515f2
Compare
89515f2
to
d3f0f92
Compare
Thanks @Dudulle for helping me with the fix. I updated the PR according to your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ssheorey and @stotko)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @stotko)
CMakeLists.txt, line 235 at r2 (raw file):
# Suppress warnings for deprecated C++17 functions. add_compile_definitions($<$<COMPILE_LANGUAGE:CUDA>:_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING>) message(WARNING "Visual Studio 16.10 introduced a compiler bug when compiling CUDA code with C++14. "
Mention MSVC version here (19.29).
d3f0f92
to
f9de553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ssheorey, @stotko, and @yxlao)
CMakeLists.txt, line 235 at r2 (raw file):
Previously, ssheorey wrote…
Mention MSVC version here (19.29).
Done.
This PR workarounds a newly introduced compiler bug in Visual Studio 16.10 when building with CUDA and C++14.
References:
expected a "("
actions/runner-images#3485This change is