Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two crash bugs on Apple Silicon #6008

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Conversation

errissa
Copy link
Collaborator

@errissa errissa commented Mar 18, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

  • Resolves one of the issues report in Segmentation Fault On Mac M2 #5951 - the crash when exiting the visualizer with ESC key.
  • Resolves compilation issue that results in C++ exceptions not being caught thereby terminating an application.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

This change is Reviewable

@errissa errissa requested a review from ssheorey March 18, 2023 00:56
@update-docs
Copy link

update-docs bot commented Mar 18, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

Hi @RohanGautam, can you test if this PR resolves your (crash when pressing ESC). Please build from source after checking out this PR.

@stefan-baumann can you test the Python unit tests on Apple M2?

Copy link

@stefan-baumann stefan-baumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end on the M2. All tests pass now, and the segfault when closing the visualizer with the escape key from #5951 (comment) seems to be fixed too.

@RohanGautam
Copy link

Echoing the same news as @stefan-baumann , all is looking good on my end too! The crash on Esc in the visualizer no longer seems to be an issue with the fixes introduced in this PR.

@ssheorey ssheorey merged commit 21e177e into master Mar 18, 2023
@ssheorey ssheorey deleted the errissa/apple-m1-exception-fix branch March 18, 2023 22:32
dbs4261 pushed a commit to dbs4261/Open3D that referenced this pull request Apr 13, 2023
* Remove -nocompact_unwind and suppress warnings instead
* Fix crash bug on Apple Silicon on closing gui window (might be Ventura-only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants