Build fixes MSVC and gcc #6039
Build fixes MSVC and gcc #6039
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Windows MSVC revert to fmt 6 gcc-12 maybe-uninitialized warning set VTK compatible version documentation for draw
ssheorey
force-pushed
the
ss/build-fixes
branch
from
f75436a
to
127e48e
Compare
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ssheorey)
|
Yesterday we talked about disabling |
We actually use a fork of the original Poisson reconstruction code and looks like we have updated the fork in the past to take care of compiler issues before. Here is the update to our fork: |
| :lineno-start: 59 | ||
| :lines: 59-72 | ||
| :lineno-start: 37 | ||
| :lines: 37-49 |
There was a problem hiding this comment.
@ssheorey These changes in non_blocking_visualization.rst are taken care of here - https://github.com/isl-org/Open3D/pull/6321/files#diff-4d3bb3b76c894acd5303dbc1d2a0d919882866be425e1ce6279c4e59c0e951c0R28 (reminding just in case).
There was a problem hiding this comment.
Thanks for checking! No worries, they will be updated when we merge #6321.
Windows MSVC revert to fmt 6: Resolves #6006
gcc-12 maybe-uninitialized warning. Resolves: #6003
Set VTK minimum version Resolves #6037
[Incomplete] documentation for draw
This change is