-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support multi-threading in the RayCastingScene function to commit scene #6051
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastienmascha Can you add a unit test checking if RayCastingScene is threadsafe?
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Hi @sebastienmascha thanks for submitting this PR! Gentle reminder about addressing @benjaminum 's comment (add unit test). |
@sebastienmascha Let us know if help is needed with the unit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Strange unit test error in WIndows (OFF, ON, OFF, Release). Will merge and check if this re-occurs:
|
Support multi-threading in the RayCastingScene function to commit scene.
Type
Motivation and Context
See #6050
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
See #6050
This change is