Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support multi-threading in the RayCastingScene function to commit scene #6051

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

sebastienmascha
Copy link
Contributor

@sebastienmascha sebastienmascha commented Apr 1, 2023

Support multi-threading in the RayCastingScene function to commit scene.

Type

Motivation and Context

See #6050

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

See #6050


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 1, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum self-assigned this Apr 1, 2023
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienmascha Can you add a unit test checking if RayCastingScene is threadsafe?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@ssheorey
Copy link
Member

ssheorey commented Jun 1, 2023

Hi @sebastienmascha thanks for submitting this PR! Gentle reminder about addressing @benjaminum 's comment (add unit test).

@benjaminum
Copy link
Contributor

@sebastienmascha Let us know if help is needed with the unit test

Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@ssheorey
Copy link
Member

ssheorey commented Aug 29, 2023

Strange unit test error in WIndows (OFF, ON, OFF, Release). Will merge and check if this re-occurs:

D:\a\Open3D\Open3D\cpp\tests\t\pipelines\registration\Registration.cpp(280): error: The difference between reg_colored_t.fitness_ and reg_colored_l.fitness_ is 0.20490959870645309, which exceeds 0.05, where
reg_colored_t.fitness_ evaluates to 0.71993973247096865,
reg_colored_l.fitness_ evaluates to 0.92484933117742174, and
0.05 evaluates to 0.050000000000000003.
D:\a\Open3D\Open3D\cpp\tests\t\pipelines\registration\Registration.cpp(282): error: The difference between reg_colored_t.inlier_rmse_ and reg_colored_l.inlier_rmse_ is 0.13259293800465694, which exceeds 0.02, where
reg_colored_t.inlier_rmse_ evaluates to 0.34763052771474739,
reg_colored_l.inlier_rmse_ evaluates to 0.21503758971009046, and
0.02 evaluates to 0.02.
[  FAILED  ] Registration/RegistrationPermuteDevices.ICPColored/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00> (42341 ms)
[ RUN      ] Registration/RegistrationPermuteDevices.ICPPointToPlane/0

@ssheorey ssheorey merged commit 9d88662 into isl-org:master Aug 29, 2023
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-threading in RaycastingScene::CastRays()
3 participants