Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax nbformat #6135

Merged
merged 1 commit into from
Jun 30, 2023
Merged

relax nbformat #6135

merged 1 commit into from
Jun 30, 2023

Conversation

Borda
Copy link
Contributor

@Borda Borda commented May 6, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

the nbformat is the only hard pin dependency which is a bit strange (I don't see a reason, but there is pls correct me), which makes a third to find an intersection with other packages
also one of the reasons in the past for pin was resolved already in 5.6.1, see: jupyter/nbformat#306 (comment)

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented May 6, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@Borda
Copy link
Contributor Author

Borda commented May 12, 2023

@yxlao @errissa @ssheorey @benjaminum could you pls check and approve running CI 🐰

Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@Borda
Copy link
Contributor Author

Borda commented May 15, 2023

@benjaminum seems that the only failed job failed to start so not even started, could you pls re-run it 🐿️

@benjaminum benjaminum self-assigned this May 23, 2023
@yxlao yxlao merged commit 47f4ee9 into isl-org:master Jun 30, 2023
@Borda Borda deleted the req/nbformat branch June 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants