Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter web_visualizer for ipywidgets 8 #6239

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Jun 30, 2023

Type

Motivation and Context

API change in ipywidgets 8

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Also changed some status messages from Info to Debug


This change is Reviewable

Changed some status messages from Info to Debug
@update-docs
Copy link

update-docs bot commented Jun 30, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from benjaminum June 30, 2023 01:47
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this issue https://stackoverflow.com/questions/71629057/how-to-solve-this-error-importerror-cannot-import-name-staticmodule-from-set
I think we should update jupyter_packaging in python/requirements_jupyter_build.txt

Reviewable status: 0 of 13 files reviewed, all discussions resolved

@ssheorey
Copy link
Member Author

I ran into this issue https://stackoverflow.com/questions/71629057/how-to-solve-this-error-importerror-cannot-import-name-staticmodule-from-set I think we should update jupyter_packaging in python/requirements_jupyter_build.txt

Reviewable status: 0 of 13 files reviewed, all discussions resolved

Thanks. Update jupyter_packaging to 0.12 and tested works.
Also tested in jupyterlab 3.6 and 4.0

(Benjamin review)
Fix style.
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 14 files reviewed, all discussions resolved

@ssheorey ssheorey merged commit 6ddbcd5 into master Jul 10, 2023
32 checks passed
@ssheorey ssheorey deleted the ss/ipywidgets8-api branch July 10, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use web visualizer and Jupyter with Python 3.10 and current Open3D 0.17.0
2 participants