Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segment plane non deterministic issue #6308

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

yuecideng
Copy link
Collaborator

@yuecideng yuecideng commented Aug 13, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

This PR fix issue #5647 and add a unit test for deterministic check of SegmentPlane.

The reason why the function is non deterministic is that, the RandomSampler is not guarded by the mutex, which may result in the order of the sampled indices mismatch among multithreading workload.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Aug 13, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@theNded theNded self-requested a review August 13, 2023 18:06
@ssheorey
Copy link
Member

Thanks @yuecideng, @theNded !

@ssheorey ssheorey merged commit 75dccb4 into master Aug 14, 2023
38 of 39 checks passed
@ssheorey ssheorey deleted the yueci/fix-seg-plane branch August 14, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants