Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional invert parameter in Pointcloud cropping (similar to tensor pointcloud) #6377

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

wakkoyankee
Copy link
Contributor

@wakkoyankee wakkoyankee commented Sep 18, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Tensor Pointcloud have the invert option in cropping but not the basic Pointcloud. Even though SelectbyIndex allows it.Needed it for a project and thought it was missing. The boolean is optional so this is minimal change.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Added optional invert bool in crop function for geometry::Pointcloud. For the unit test i reused the previous cropping tests but inverted the results.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Sep 18, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review September 21, 2023 23:38
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wakkoyankee !

@ssheorey ssheorey merged commit ea2001f into isl-org:master Sep 28, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants