Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on non-contiguous Python buffer provided to Image ctor. #6406

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Oct 4, 2023

Type

Motivation and Context

Cropped images (e.g. from OpenCV) provided to Open3D Image ctor are not supported. In tensor API, an error is thrown, while in Eigen API they are silently accepted with errorneous results. This PR raises an error in the Eigen API. See #6403 for a test script and details.

Thanks to @myalos for reporting and debugging. Also thanks to @saurabheights for help

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

This change is Reviewable

@update-docs
Copy link

update-docs bot commented Oct 4, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ssheorey)

@errissa errissa merged commit a1ae217 into master Oct 13, 2023
39 of 40 checks passed
@ssheorey ssheorey deleted the ss/eigen-image-non-cont branch December 30, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why the cropped rgb and the cropped depth produce weird pointcloud? Amazing...
2 participants