Add Missing Python Bindings and Add/Update Docstrings #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
ssheorey
requested changes
Oct 13, 2023
ssheorey
reviewed
Oct 14, 2023
cpp/pybind/visualization/gui/gui.cpp
Outdated
| @@ -1550,6 +1550,11 @@ void pybind_gui_classes(py::module &m) { | |||
| .def("remove_item", &TreeView::RemoveItem, | |||
| "Removes an item and all its children (if any)") | |||
| .def("clear", &TreeView::Clear, "Removes all items") | |||
| .def("get_item", &TreeView::GetItem, | |||
There was a problem hiding this comment.
Document arguments here as well.
errissa
changed the title
ssheorey
approved these changes
Dec 29, 2023
ssheorey
force-pushed
the
errissa/missing-pybinds
branch
from
67bcb1b to
c29a473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Adds missing Python bindings to
Sceneclass for controlling object properties such as culling (which provides partial solution to #6427) and toTreeViewclass for retrieving selected widget (addresses #6413)Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This change is