Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IntegrateRGBD example compilation #6453

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix IntegrateRGBD example compilation #6453

merged 1 commit into from
Oct 31, 2023

Conversation

sitic
Copy link
Contributor

@sitic sitic commented Oct 26, 2023 •
edited
Loading

Compilation of Open3D failed for gcc-12 with:

examples/cpp/IntegrateRGBD.cpp:71:15: error: argument 1 null where non-null expected [-Werror=nonnull]
   71 |         fclose(file);

Since file is already NULL, we shouldn't try to fclose() it.

Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

This change is Reviewable

@sitic
Fix IntegrateRGBD example compilation
acdef57 
Compilation failed for gcc-12 with:
```
examples/cpp/IntegrateRGBD.cpp:71:15: error: argument 1 null where non-null expected [-Werror=nonnull]
   71 |         fclose(file);
```
@update-docs
Copy link

update-docs bot commented Oct 26, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

benjaminum
benjaminum approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@ssheorey ssheorey merged commit dfedea7 into isl-org:master Oct 31, 2023
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminum benjaminum benjaminum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sitic @benjaminum @ssheorey