Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep output of cell blocks in jupyter in scrollable area #6504

Merged

Conversation

saurabheights
Copy link
Contributor

Type

Motivation and Context

See #6502

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Nov 23, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@saurabheights
Copy link
Contributor Author

Is it ok if I also remove the cellnumber output from notebook. Check the number on left of code blocks here - http://www.open3d.org/docs/latest/tutorial/pipelines/rgbd_odometry.html#Compute-odometry-from-two-RGBD-image-pairs. IMO, The [4]: is of no help, and breaks the content layout making reading more straining, albeit slightly.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @saurabheights

@ssheorey ssheorey merged commit 680d663 into isl-org:master Dec 6, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Furo theme does not handle large output from nbsphinx
2 participants