Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master -> main for branches #6530

Merged
merged 3 commits into from
Dec 11, 2023
Merged

master -> main for branches #6530

merged 3 commits into from
Dec 11, 2023

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Dec 9, 2023

master -> primary elsewhere
3rdparty urls not modified

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

@ssheorey
master -> main for branches
531f9e9 
master -> primary elsewhere
3rdparty urls not modified
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ssheorey ssheorey requested a review from errissa December 9, 2023 20:14
errissa
errissa approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I searched the repo for any further references to master branch and couldn't find any.

@ssheorey
Copy link
Member Author

Seg fault in CUDA for Python select_by_index for t.TriangleMesh is unrelated and needs a separate PR.

@ssheorey ssheorey merged commit 4cafeee into main Dec 11, 2023
29 of 35 checks passed
@ssheorey ssheorey deleted the ss/master2main branch December 11, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errissa errissa errissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssheorey @errissa