Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var to disable automatic WebVisualizer use in Jupyter environment #6541

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

gutnar
Copy link
Contributor

@gutnar gutnar commented Dec 18, 2023

Add checking DISABLE_OPEN3D_WEB_VISUALIZER environment variable to disable automatically enabling web visualizer when in a Jupyter environment.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

The problem is that when using the Jupyter extension in Visual Studio Code then the web visualizer does not function. This change allows to set an environment variable so that the web visualizer would not automatically be enabled.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

When using the gui.Application functionality and running it using the Jupyter extension in Visual Studio Code then no visualization appears. When setting the env var DISABLE_OPEN3D_WEB_VISUALIZER=True then the WebVisualizer is not enabled and an application window opens.

Copy link

update-docs bot commented Dec 18, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gutnar for this useful update. I added docs, allowed lower case env var and made OPEN3D the prefix for the env var.

@ssheorey ssheorey merged commit bd869d4 into isl-org:main Dec 26, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants