Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring updates for NearestNeighborSearch and compute_metrics #7081

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

benjaminum
Copy link
Contributor

@benjaminum benjaminum commented Nov 29, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

  • Adding missing documentation and improving format issues for some docstrings for PointCloud and TriangleMesh
  • Fix unknown escape sequence warning in make_docs.py
  • Proposal of a template docstring to point out pitfalls and make writing docstrings easier template

The rendered template looks like this

image

Copy link

update-docs bot commented Nov 29, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum requested a review from ssheorey December 4, 2024 15:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some info on writing docs here:

https://www.open3d.org/docs/latest/contribute/contribution_recipes.html#documentation

docs/contribute/contribution_recipes.rst

Can we merge these two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can and we should remove the docstring::XDocInject parts in "Case 2". It is over engineered and makes updating the documentation difficult due to the multiple locations in the same file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@benjaminum benjaminum requested a review from ssheorey December 9, 2024 08:09
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sphinx-tabs and sphinx-copybutton are great!

@ssheorey ssheorey merged commit f2461a3 into main Dec 11, 2024
32 of 44 checks passed
@ssheorey ssheorey deleted the bu/docstring_updates branch December 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants