Quentin leboutet/ios consistent UI #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thias15
reviewed
May 23, 2023
| } | ||
|
|
||
| layout.collectionView?.backgroundColor = Colors.voltageDividerColor |
There was a problem hiding this comment.
Why is this color called voltageDividerColor?
There was a problem hiding this comment.
It is the green gauge in the freeroam fragment.
There was a problem hiding this comment.
Seems better practice to define a separate color (even if same RGB value) or give it a neutral name.
ios/OpenBot/OpenBot/Controllers/HomePage/HomePageViewController.swift
Outdated
Show resolved
Hide resolved
ios/OpenBot/OpenBot/Controllers/HomePage/HomePageViewController.swift
Outdated
Show resolved
Hide resolved
ios/OpenBot/OpenBot/Controllers/HomePage/HomePageViewController.swift
Outdated
Show resolved
Hide resolved
|
Great. Did you already test this on small + large screen device? |
|
Also, please update README with updated screenshots. |
|
Done |
thias15
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of changes on the iOS UI to better match the android UI.