feat(rental-agreement): Continue to signing screen #17392

hebaulf · 2025-01-02T16:03:02Z

Alert message to summary

https://app.asana.com/0/1208271027457465/1208557871739584/f

What

Add alert message if there are missing elements needed to finish the rental agreement
Cleaned up components
Other minor updates and fixes

Why

A party to the agreement can choose to proceed with the signing of the agreement from the Summary.

Screenshots / Gifs

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2025-01-02T16:03:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

datadog-island-is · 2025-01-02T16:35:27Z

Datadog Report

All test runs fce76d9 🔗

❌ 10 Total Test Services: 1 Failed, 9 Passed
🔻 Test Sessions change in coverage: 2 decreased, 21 increased, 176 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Passed	Total Time	Code Coverage Change	Test Service View
`api-domains-driving-license`	3	20	27.79s	1 no change	Link
`air-discount-scheme-backend`	0	63	16.1s	N/A	Link
`air-discount-scheme-web`	0	2	6.6s	N/A	Link
`api`	0	4	2.37s	N/A	Link
`api-catalogue-services`	0	23	8.96s	N/A	Link
`api-domains-air-discount-scheme`	0	6	16.44s	N/A	Link
`api-domains-assets`	0	3	9.66s	N/A	Link
`api-domains-auth-admin`	0	18	10.23s	N/A	Link
`api-domains-communications`	0	5	32.45s	N/A	Link
`api-domains-criminal-record`	0	5	8.88s	N/A	Link

❌ Failed Tests (3)

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": true,
       },
 ...

DrivingLicenseService getApplicationEligibility all checks should pass for applicable students for temporary license - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -1,10 +1,10 @@
   Object {
     "isEligible": true,
     "requirements": Array [
       Object {
 ...

DrivingLicenseService getApplicationEligibility checks should fail for non-applicable students - libs/api/domains/driving-license/src/lib/drivingLicense.spec.ts - Details

Expand for error

 expect(received).toStrictEqual(expected) // deep equality
 
 - Expected  - 1
 + Received  + 1
 
 @@ -8,11 +8,11 @@
       Object {
         "key": "DrivingSchoolMissing",
         "requirementMet": false,
       },
 ...

🔻 Code Coverage Decreases vs Default Branch (2)

services-user-profile - jest 49.27% (-0.03%) - Details
services-auth-delegation-api - jest 50.45% (-0.02%) - Details

codecov · 2025-01-03T10:33:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.69%. Comparing base (330c08b) to head (0746c04).

Additional details and impacted files

@@                      Coverage Diff                      @@
##           rental-agreement-application   #17392   +/-   ##
=============================================================
  Coverage                         35.68%   35.69%           
=============================================================
  Files                              6931     6931           
  Lines                            148798   148806    +8     
  Branches                          42511    42513    +2     
=============================================================
+ Hits                              53102    53110    +8     
  Misses                            95696    95696

Flag	Coverage Δ
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`38.02% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.42% <ø> (ø)`
api-domains-criminal-record	`48.07% <ø> (ø)`
api-domains-health-insurance	`35.52% <ø> (ø)`
api-domains-mortgage-certificate	`35.27% <ø> (ø)`
api-domains-payment-schedule	`42.15% <ø> (ø)`
application-api-files	`62.06% <ø> (ø)`
application-core	`75.79% <ø> (ø)`
application-system-api	`38.73% <ø> (-0.02%)`	⬇️
application-template-api-modules	`27.69% <ø> (+<0.01%)`	⬆️
application-templates-accident-notification	`27.61% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.83% <ø> (ø)`
application-templates-driving-license	`18.15% <ø> (ø)`
application-templates-estate	`13.66% <ø> (ø)`
application-templates-example-payment	`24.69% <ø> (ø)`
application-templates-financial-aid	`14.45% <ø> (ø)`
application-templates-general-petition	`23.12% <ø> (ø)`
application-templates-inheritance-report	`6.59% <ø> (ø)`
application-templates-marriage-conditions	`15.18% <ø> (ø)`
application-templates-mortgage-certificate	`43.79% <ø> (ø)`
application-templates-parental-leave	`29.92% <ø> (ø)`
application-types	`6.45% <ø> (ø)`
application-ui-components	`1.22% <ø> (ø)`
application-ui-shell	`22.25% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.52% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.88% <ø> (ø)`
clients-driving-license	`40.95% <ø> (ø)`
clients-driving-license-book	`43.95% <ø> (ø)`
clients-financial-statements-inao	`49.74% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`73.18% <ø> (+0.24%)`	⬆️
clients-regulations	`43.04% <ø> (ø)`
clients-rsk-company-registry	`31.18% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.50% <ø> (ø)`
clients-zendesk	`50.70% <ø> (ø)`
cms	`0.39% <ø> (ø)`
cms-translations	`38.76% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.71% <ø> (ø)`
dokobit-signing	`62.27% <ø> (ø)`
email-service	`60.23% <ø> (ø)`
feature-flags	`90.90% <ø> (ø)`
file-storage	`46.07% <ø> (ø)`
financial-aid-backend	`51.43% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
icelandic-names-registry-backend	`54.33% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.94% <ø> (ø)`
island-ui-core	`30.42% <ø> (ø)`
judicial-system-api	`20.20% <ø> (ø)`
judicial-system-audit-trail	`69.10% <ø> (ø)`
judicial-system-backend	`55.97% <ø> (ø)`
judicial-system-formatters	`78.50% <ø> (ø)`
judicial-system-message	`66.66% <ø> (ø)`
judicial-system-message-handler	`48.41% <ø> (ø)`
judicial-system-scheduler	`71.17% <ø> (ø)`
judicial-system-types	`41.60% <ø> (ø)`
judicial-system-web	`27.75% <ø> (ø)`
license-api	`42.95% <ø> (-0.13%)`	⬇️
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (+0.70%)`	⬆️
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`76.51% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`51.12% <ø> (-0.38%)`	⬇️
nest-problem	`45.64% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.13% <ø> (ø)`
nova-sms	`61.61% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.58% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
services-auth-admin-api	`52.54% <ø> (ø)`
services-auth-delegation-api	`58.47% <ø> (ø)`
services-auth-ids-api	`52.57% <ø> (-0.02%)`	⬇️
services-auth-public-api	`49.42% <ø> (-0.01%)`	⬇️
services-sessions	`65.33% <ø> (-0.05%)`	⬇️
services-university-gateway	`49.59% <ø> (ø)`
services-user-notification	`46.54% <ø> (+0.03%)`	⬆️
services-user-profile	`56.89% <ø> (-0.09%)`	⬇️
shared-components	`29.49% <ø> (ø)`
shared-form-fields	`33.38% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.26% <ø> (ø)`
web	`2.40% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330c08b...0746c04. Read the comment docs.

…sland.is into feat/continue-to-signing-screen

Add alert message to summary. Cleanup components. Other minor fixes.

c57188f

hebaulf requested a review from a team as a code owner January 2, 2025 16:03

Reorder imports for consistency

0b7d033

Merge branch 'rental-agreement-application' of github.com:island-is/i…

0746c04

…sland.is into feat/continue-to-signing-screen

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rental-agreement): Continue to signing screen #17392

feat(rental-agreement): Continue to signing screen #17392

hebaulf commented Jan 2, 2025

coderabbitai bot commented Jan 2, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

datadog-island-is bot commented Jan 2, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading

feat(rental-agreement): Continue to signing screen #17392

Are you sure you want to change the base?

feat(rental-agreement): Continue to signing screen #17392

Conversation

hebaulf commented Jan 2, 2025

Alert message to summary

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Jan 2, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

datadog-island-is bot commented Jan 2, 2025 • edited Loading

Datadog Report

❌ Failed Tests (3)

🔻 Code Coverage Decreases vs Default Branch (2)

codecov bot commented Jan 3, 2025 • edited Loading

Codecov Report

datadog-island-is bot commented Jan 2, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading