Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring animations #441

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Dec 6, 2024

When using the carousel, which now uses animation events since #434, some animations might have nothing to do with calculating the carousel and produce unnecessary and wrong calculations

This PR now ignores infinite animations and allows for a prop to explicitely remove other animations or all animations calculations

FIxes #451

Rebased on #450

I also fixed some small issues here and there:

  1. Unecessary updates when vModel changes
  2. Restore the scope id to the current instance so that the later h() calls get the correct css scope
    component as props, they are passed as $attrs and so currently have no effects

@Tofandel Tofandel force-pushed the feat/allow-disabling-animations branch 13 times, most recently from 83089c6 to 0bf025c Compare December 9, 2024 14:52
@Tofandel Tofandel force-pushed the feat/allow-disabling-animations branch from 0bf025c to 318fd19 Compare December 11, 2024 10:39
@Tofandel Tofandel force-pushed the feat/allow-disabling-animations branch from ec0290e to 22df8b6 Compare December 11, 2024 10:50
@Tofandel Tofandel force-pushed the feat/allow-disabling-animations branch from 22df8b6 to d2d605e Compare December 11, 2024 10:54
@ismail9k ismail9k merged commit 0234cd8 into ismail9k:master Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slide size not refreshing
2 participants