445 configurable cloned items for wrap around #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te cloned slides as needed
Tofandel
reviewed
Dec 25, 2024
| const before = Math.min(slidesToClone, activeSlideIndex.value) | ||
| const after = Math.min( | ||
| slidesToClone, | ||
| slidesCount.value - activeSlideIndex.value - 1 |
There was a problem hiding this comment.
This calculation for while dragging does not seem correct, if you have 10 slides and are on slide 9 (the last slide), you get after = 0 and it should be the other way around, when you arrive close to the end it should start from 0 and start increasing (it should also include the offset)
I think it should look something more like activeSlideIndex.value + ceil((offset + itemsToShow) / 2) - slidesCount,
There was a problem hiding this comment.
Thank you for pointing this out. Indeed, the equation should have been:
slidesToClone - (slidesCount.value - activeSlideIndex.value - 1)
Let’s consider an example where slidesToClone = 2 and slidesCount = 10. Below is the calculation for different values of activeSlideIndex ranging from 8 to 11:
| activeSlideIndex | Calculation | Result |
|---|---|---|
| 8 | 2 - (10 - 8 - 1) = 2 - (1) | 1 |
| 9 | 2 - (10 - 9 - 1) = 2 - (0) | 2 |
| 10 | 2 - (10 - 10 - 1) = 2 - (-1) | 3 |
| 11 | 2 - (10 - 11 - 1) = 2 - (-2) | 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #445