Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preventExcessiveDragging option to limit boundary slide gestures #468

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

aovcina
Copy link
Contributor

@aovcina aovcina commented Jan 3, 2025

@aovcina aovcina changed the title feat: add preventExcessiveDragging option to limit boundary slide ges… feat: add preventExcessiveDragging option to limit boundary slide gestures Jan 3, 2025
@ismail9k
Copy link
Owner

ismail9k commented Jan 4, 2025

Thank you, @aovcina, for your PR! I've reviewed it and found some edge cases where unusual behavior occurs during aggressive dragging. Instead of abruptly cutting off the drag action, I suggest preventing the track sliding from exceeding its thresholds by dynamically adjusting the trackTransform computed variable.

@aovcina
Copy link
Contributor Author

aovcina commented Jan 4, 2025

@ismail9k, thank you for the feedback. I've reviewed and tested made changes and you're right. It's better to handle it within the trackTransform computed. Along the way, I've added prop validation so developers are informed that the newly added preventExcessiveDragging option cannot work with wrapAround. Also, I've added a badge in the docs for the new config property with the upcoming minor version that indicates its availability. Please amend if needed.

@ismail9k ismail9k merged commit 8d01e32 into ismail9k:master Jan 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants