Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Cannot read property text of undefined" #10

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

levity
Copy link
Contributor

@levity levity commented Oct 3, 2016

This is similar to #9 but it's a bit cleaner and addresses one more place where the error can occur.

@yahoocla
Copy link

yahoocla commented Oct 3, 2016

CLA is valid!

@MinweiShen
Copy link

Solves my problem!

@dennybiasiolli
Copy link

Works for me too

@bcoe
Copy link
Contributor

bcoe commented Oct 16, 2016

@levity sorry for the slow turnaround on this, mind rebasing and I'll get it shipped ASAP?

bcoe pushed a commit that referenced this pull request Oct 17, 2016
@bcoe bcoe merged commit bed1d13 into istanbuljs-archived-repos:master Oct 17, 2016
bcoe pushed a commit that referenced this pull request Oct 17, 2016
bcoe added a commit that referenced this pull request Oct 17, 2016
@bcoe
Copy link
Contributor

bcoe commented Oct 30, 2016

@levity @dennybiasiolli @MinweiShen this will be shipped in the next release of nyc, I would love the extra help testing (as there are a few big features going out in this release as well).

npm cache clear; npm i nyc@next

@satyendra-singh
Copy link

nothing is wrong with node module.
I also had same problem and googled all the day to figure this out... finally I found special characters in my code -- it was <U+2028>
that was causing problem
istanbul go through entire code for coverage.
I removed all special character and ran test cases again.
every thing works fine.

@bcoe
Copy link
Contributor

bcoe commented Feb 22, 2017

@satyendra-singh this is an interesting bug! if it's reproducable, perhaps you could open a separate ticket and we can dig into it?

@glazar
Copy link

glazar commented Jun 7, 2017

@levity We should also port these changes to https://github.com/gotwarlost/istanbul/blob/master/lib/report/html.js.
I ran into a similar issue with a setup involving the above mentioned file, and the fix is not yet to be found there. I can create a PR for that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants