-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace source-map
with @jridgewell/trace-mapping
#185
Comments
I currently only track from generated -> original positions. I think I can add a lazy initialize for original -> generated position without affecting, which should still be fast. Although, you're only usage of |
If it can be done in a better way, that's of course preferable 😀 I doubt @bcoe is particularly bound to the current implementation |
Turns out there's not a faster algorithm that we can do. I misunderstood the API you were trying to implement, and in order to find the start of the next segment in source order, you need to use |
Sweet, thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes #185.
According to its benchmarks, it's way quicker, and it doesn't require us to use async code. Main motivation however, is that 0.7 of
source-map
is completely broken on the upcoming node v18: nodejs/node#42638I tried a quick migration, but
v8-to-istanbul
usesconsumer.generatedPositionFor
, which doesn't exist in@jridgewell/trace-mapping
./cc @jridgewell
The text was updated successfully, but these errors were encountered: