Skip to content

Commit

Permalink
Feat: Add tooltip to question item of ChunkCreatingModal infiniflow#3873
Browse files Browse the repository at this point in the history
 (infiniflow#3880)

### What problem does this PR solve?

Feat: Add tooltip to question item of ChunkCreatingModal  infiniflow#3873

### Type of change


- [x] New Feature (non-breaking change which adds functionality)
  • Loading branch information
cike8899 authored Dec 5, 2024
1 parent 1f0a153 commit 3a0e9f9
Show file tree
Hide file tree
Showing 7 changed files with 39 additions and 35 deletions.
23 changes: 18 additions & 5 deletions web/src/components/edit-tag/index.less
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
.tweenGroup {
display: inline-block;
:global(.ant-tag) {
margin-bottom: 8px;
font-size: 14px;
padding: 2px 8px;
display: flex;
gap: 8px;
flex-wrap: wrap;
width: 100%;
margin-bottom: 8px;
}

.tag {
max-width: 100%;
margin: 0;
padding: 2px 20px 2px 4px;
font-size: 14px;
.textEllipsis();
position: relative;
:global(.ant-tag-close-icon) {
position: absolute;
top: 7px;
right: 4px;
}
}
17 changes: 7 additions & 10 deletions web/src/components/edit-tag/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ const EditTag = ({ tags, setTags }: EditTagsProps) => {
};

const forMap = (tag: string) => {
const tagElem = (
return (
<Tag
key={tag}
className={styles.tag}
closable
onClose={(e) => {
e.preventDefault();
Expand All @@ -56,11 +58,6 @@ const EditTag = ({ tags, setTags }: EditTagsProps) => {
{tag}
</Tag>
);
return (
<span key={tag} style={{ display: 'inline-block' }}>
{tagElem}
</span>
);
};

const tagChild = tags?.map(forMap);
Expand All @@ -71,8 +68,8 @@ const EditTag = ({ tags, setTags }: EditTagsProps) => {
};

return (
<>
<span>
<div>
{Array.isArray(tagChild) && tagChild.length > 0 && (
<TweenOneGroup
className={styles.tweenGroup}
enter={{
Expand All @@ -91,7 +88,7 @@ const EditTag = ({ tags, setTags }: EditTagsProps) => {
>
{tagChild}
</TweenOneGroup>
</span>
)}
{inputVisible ? (
<Input
ref={inputRef}
Expand All @@ -107,7 +104,7 @@ const EditTag = ({ tags, setTags }: EditTagsProps) => {
<PlusOutlined />
</Tag>
)}
</>
</div>
);
};

Expand Down
1 change: 1 addition & 0 deletions web/src/locales/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ When you want to search the given knowledge base at first place, set a higher pa
graph: 'Knowledge graph',
mind: 'Mind map',
question: 'Question',
questionTip: `If there're given questions, the embedding of the chunk will be based on them.`,
},
chat: {
newConversation: 'New conversation',
Expand Down
1 change: 1 addition & 0 deletions web/src/locales/zh-traditional.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ export default {
graph: '知識圖譜',
mind: '心智圖',
question: '問題',
questionTip: `如果存在給定的問題,則區塊的嵌入將基於它們。`,
},
chat: {
newConversation: '新會話',
Expand Down
1 change: 1 addition & 0 deletions web/src/locales/zh.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ export default {
graph: '知识图谱',
mind: '思维导图',
question: '问题',
questionTip: `如果有给定的问题,则块的嵌入将基于它们。`,
},
chat: {
newConversation: '新会话',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import EditTag from '@/components/edit-tag';
import { useFetchChunk } from '@/hooks/chunk-hooks';
import { IModalProps } from '@/interfaces/common';
import { DeleteOutlined } from '@ant-design/icons';
import { Divider, Form, Input, Modal, Space, Switch } from 'antd';
import { DeleteOutlined, QuestionCircleOutlined } from '@ant-design/icons';
import { Divider, Form, Input, Modal, Space, Switch, Tooltip } from 'antd';
import React, { useEffect, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useDeleteChunkByIds } from '../../hooks';
Expand Down Expand Up @@ -41,7 +41,7 @@ const ChunkCreatingModal: React.FC<IModalProps<any> & kFProps> = ({
form.setFieldsValue({ content: content_with_weight });
setKeywords(important_kwd);
setQuestion(question_kwd);
setChecked(available_int === 1);
setChecked(available_int !== 0);
}

if (!chunkId) {
Expand Down Expand Up @@ -93,11 +93,16 @@ const ChunkCreatingModal: React.FC<IModalProps<any> & kFProps> = ({
</Form.Item>
</Form>
<section>
<p className="mb-2">{t('chunk.keyword')} *</p>
<p className="mb-2">{t('chunk.keyword')} </p>
<EditTag tags={keywords} setTags={setKeywords} />
</section>
<section className="pt-2">
<p className="mb-2">{t('chunk.question')} *</p>
<section className="mt-4">
<div className="flex items-center gap-2 mb-2">
<span>{t('chunk.question')}</span>
<Tooltip title={t('chunk.questionTip')}>
<QuestionCircleOutlined className="text-xs" />
</Tooltip>
</div>
<EditTag tags={question} setTags={setQuestion} />
</section>
{chunkId && (
Expand Down
14 changes: 0 additions & 14 deletions web/src/utils/file-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,6 @@ export const downloadFileFromBlob = (blob: Blob, name?: string) => {
window.URL.revokeObjectURL(url);
};

export const downloadFile = async ({
id,
filename,
target,
}: {
id: string;
filename?: string;
target?: string;
}) => {
const response = await fileManagerService.getFile({}, id);
const blob = new Blob([response.data], { type: response.data.type });
downloadFileFromBlob(blob, filename);
};

export const downloadDocument = async ({
id,
filename,
Expand Down

0 comments on commit 3a0e9f9

Please sign in to comment.