update theme provider

isthaison · Dec 4, 2024 · b91187e · b91187e
1 parent 7fbf5ad
commit b91187e
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/web/src/components/theme-provider.tsx b/web/src/components/theme-provider.tsx
@@ -1,4 +1,4 @@
-import { createContext, useContext, useEffect, useState } from 'react';
+import React, { createContext, useContext, useEffect, useState } from 'react';
 
 type Theme = 'dark' | 'light' | 'system';
 
@@ -44,20 +44,18 @@ export function ThemeProvider({
       root.classList.add(systemTheme);
       return;
     }
-
+    localStorage.setItem(storageKey, theme);
     root.classList.add(theme);
-  }, [theme]);
-
-  const value = {
-    theme,
-    setTheme: (theme: Theme) => {
-      localStorage.setItem(storageKey, theme);
-      setTheme(theme);
-    },
-  };
+  }, [storageKey, theme]);
 
   return (
-    <ThemeProviderContext.Provider {...props} value={value}>
+    <ThemeProviderContext.Provider
+      {...props}
+      value={{
+        theme,
+        setTheme,
+      }}
+    >
       {children}
     </ThemeProviderContext.Provider>
   );